Motion: allow creating sequenceless motions with raw pointers#54
Open
mardy wants to merge 8 commits into
Open
Conversation
mardy
force-pushed
the
sequenceless-raw-apply
branch
from
a0b5652 to
697ee12
Compare
This fixes a couple of conversion issues:
.../src/choreograph/Motion.hpp:182:24: warning: comparison of integer expressions of different signedness: 'int' and 'unsigned int' [-Wsign-compare]
182 | if( inflection > bottom && inflection <= top ) {
| ~~~~~~~~~~~^~~~~~~~
.../src/choreograph/Motion.hpp:182:47: warning: comparison of integer expressions of different signedness: 'int' and 'unsigned int' [-Wsign-compare]
182 | if( inflection > bottom && inflection <= top ) {
| ~~~~~~~~~~~^~~~~~
mardy
force-pushed
the
sequenceless-raw-apply
branch
from
697ee12 to
abab155
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi David, thanks for this nice project! I hope you are still maintaining it :-)
I had some trouble to create a timeline with raw pointers: the code
m_timeline.applyRaw(&m_currentPositions[source]). then<ch::RampTo>(m_points[target], 0.3);would not compile (
m_currentPositionsis astd::vectorof aPointclass of mine). Adding the Motion constructor proposed in this PR fixed the issue for me.Maybe there was a specific reason why this constructor was not added?