feat(pricingx,storagex): gold/mutual-fund live providers + storage ab… - #19
Merged
Conversation
…straction pricingx: - YahooGold provider: fetches GC=F (gold futures USD/oz) + USDIDR=X (USD/IDR), converts to IDR/gram (÷ 31.1034768). Category "gold". (T047) - NewYahooMutualFund: Yahoo Finance NAV provider for category "mutual_fund"; falls back to stale on failure per Constitution IV. (T049) - Refactor Yahoo.GetPrice to share fetchYahooChart helper with YahooGold. storagex: - Storage interface: Put/Get/Delete for binary blobs. (T016) - MemStorage: in-memory implementation for tests. - LocalStorage: local filesystem implementation for development. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_016Ja58bJ35AXEd4hn9VVTgP
…indows CI) Windows holds an exclusive lock on open file handles; os.Remove fails with "file is being used by another process" if the handle is still open. Replace defer r.Close() with an explicit r.Close() before s.Delete(). Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_016Ja58bJ35AXEd4hn9VVTgP
GoReleaser v2.17.0 removed 'conventional-commits' as a valid changelog.use value. Switch to 'git' which honours the existing sort/filter configuration. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_016Ja58bJ35AXEd4hn9VVTgP
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…straction
pricingx:
storagex:
Claude-Session: https://claude.ai/code/session_016Ja58bJ35AXEd4hn9VVTgP
Summary
Checklist
make test→ green)make coverage— core ≥ 85%, security ≥ 95%)CHANGELOG.mdupdated under[Unreleased]!in commit /BREAKING CHANGE:footergo mod tidyrun — no stale entries ingo.summake lintpasses with zero new warningsRelated Issues