perf(coding-agent): composer is on screen from the first paint — no slide-up on load - #901
Open
santhreal wants to merge 1 commit into
Open
perf(coding-agent): composer is on screen from the first paint — no slide-up on load#901santhreal wants to merge 1 commit into
santhreal wants to merge 1 commit into
Conversation
…up on load The first frame reserved eight blank rows where the composer would live and left them empty until InteractiveMode.init finished (slash command discovery, recent-session reads), so the prompt arrived late and read as sliding up into place. The first frame now paints the resting composer through a static component shared with the mounted zone: real hairline bytes, the same ghost placeholder, the exact resting row count. The handover swaps text, never position.
|
Important
This repository does not receive automatic reviews because it has fewer than 10 stars. ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Cold launch used to reserve eight blank rows at the bottom of the screen where the composer would live, then leave them empty while
InteractiveMode.initfinished (slash-command discovery, recent-session reads). When init completed, the real zone mounted into the reserved space and the prompt appeared late — reading as the composer sliding up into place.The first frame now paints a static resting composer (
StaticComposerFrame) into those rows: the real hairline bytes fromComposerHairline, the shared ghost placeholder (COMPOSER_PLACEHOLDER, moved to composer-chrome as the one owner), clipped to width, exactly the resting zone's row count. When the mode finishes initializing, the real zone mounts into the same rows — the handover changes text, never position. Nothing slides; nothing animates.Why
Startup should feel literal: what you see at frame one is the product. An empty hole where the input obviously belongs reads as loading, and on slower disks (Windows cold caches) that hole sat there for seconds.
Testing
packages/coding-agent/test/the-first-frame-paints-the-composer-instantly.test.ts— closes the class "the first-frame composer drifts from the mounted one": exact reserved row count, real hairline bytes (same owner), shared ghost placeholder, time-invariance (no animation), narrow-width clipping.bun run check:ts,bun run check:toolsclean.bun checkpasses