Repository navigation
fix(ci): verify Mac certificates with the supported codesign interface - #102
Merged
Merged
Conversation
Scope public payload creation to Xcode archive and export subprocesses while retaining private signing credentials. Reject unreadable macOS archive entries before upload and include the same guard in local release preflight.
Bind standing owner authorization to independently reviewed source 81fa045, conditional on required hosted checks and current Codex review passing before merge and delivery.
Retain the runner's configured official HTTPS fallback instead of its repeatedly stalled Azure HTTP mirror. Bound APT connection and data waits, preserve package trust, and cover Linux setup, macOS skip, idempotency, missing fallback, and privileged-operation failures.
Bind standing owner authorization to reviewed source 8a30e2c, conditional on required hosted checks and current Codex review before merge and macOS delivery.
Regenerate the wrapper with the verified Gradle 9.8.1 security patch and official distribution checksum. Align native toolchain documentation and clear exact-source approval until the corrected release revision is reviewed.
Record standing publication authority for source 3632596. Delivery remains conditional on green hosted checks and current Codex review; preserve immutable v4 artifacts and existing store reviews.
Archive the Mac app and Swift resource bundles with the validated distribution certificate. Scope the provisioning profile to the application and reject nested certificate mismatches before export and upload. Preserve the existing iOS delivery flow.
Generate isolated synthetic certificates with the system tool on Apple and Linux runners without requiring a package binary.
Record existing conditional publication authorization for the independently reviewed source after local validation. Require green hosted checks and current Codex review before merge or delivery.
Keep real Back dismissal coverage while waiting for Android popup window focus. Reset source-bound approval until the reviewed correction is committed.
Apply standing authorization to the locally validated Mac delivery and Android input-focus correction. Required hosted checks and current Codex review still gate protected merge.
Attach the optional certificate prefix to the codesign extraction flag. Exercise the real macOS tool in the required Apple checks and preserve diagnostic context without weakening distribution signature verification.
Record standing conditional authorization for reviewed source eea78c5. Require hosted checks and current Codex review before protected merge and Mac delivery.
Owner
Author
|
@codex review |
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
Codex Review: Didn't find any major issues. Can't wait for the next one! Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Mac delivery archived the app and its Swift resource bundle with the correct distribution certificate, then stopped before export because the signature guard passed the optional certificate prefix as a separate codesign argument. Attach the prefix to the flag, preserve diagnostic context, and exercise the real macOS tool during the required Apple checks so this interface regression is detected before merge.
Validation: full
pnpm run validate,pnpm run ci:preflight, independent read-only review, and 13 focused signing/delivery/profile tests passed locally, including the actual macOS certificate extraction test. Hosted checks and current-head Codex review remain required before protected merge and delivery.Lumen stays 4.0.0 and playgrounds stay 1.0.3. This changes release validation only; no consumer migration. Existing published tags/artifacts and approved iOS/Android submissions and rollout holds remain intact. Recovery is a new reviewed merged-main delivery; retain the currently published Mac version if delivery or store validation fails.