Repository navigation
fix(site): open mobile navigation before dialog scripts load - #59
Merged
Merged
Conversation
Use native dialog commands while Lumen initializes, retaining its existing fallback. Reproduce the delayed-controller failure and cover early pointer and keyboard input, dismissal, and initialized fallback behavior. Prepare the independent site 0.3.1 patch before publishing Quality 1.4.0.
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The first mobile-menu click on the deployed site was lost while Lumen’s dialog controller downloaded (reproduced in all five production retries after #56 merged). Native
command/commandforattributes now open and close the existing Lumen dialog immediately in supporting browsers. Lumen retains its existing fallback for browsers without native command support.The regression deliberately holds the controller request, exercises pointer and keyboard activation, close and Escape, then verifies the initialized Lumen fallback with native command attributes removed. Site version 0.3.1 and its changelog were generated through Changesets; CLI and Action remain at the unpublished 1.4.0.
Validation:
pnpm validatepassed, including zero-warning quality checks, tests, builds, dependency audit, version consistency, and Action bundle verification.CI=true pnpm test:site: 64 passed, 2 expected desktop skips for mobile-only contracts.Release completion:
http-cache-semantics4.3.0 OpenSSF warning remains documented in RELEASING.md without suppressions or lowered thresholds. No wider pilot rollout is included here.