Skip to content

fix(desktop): align import type controls #48

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
santosli merged 1 commit into from
Aug 1, 2026
+23 −2
Merged

fix(desktop): align import type controls #48

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 10 additions & 1 deletion apps/desktop/src/cardLayout.test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -440,6 +440,11 @@ test('import candidate groups disclose locations and use radio variant selection
const typeActionRule = css.match(/\.candidateTypeAction\s*\{(?<body>[^}]*)\}/s)?.groups.body || '';
const requiredTypeActionRule = css.match(/\.candidateTypeAction\.required\s*\{(?<body>[^}]*)\}/s)
?.groups.body || '';
const typeActionSwitchRule = css.match(/\.candidateTypeAction \.candidateTypeSwitch\s*\{(?<body>[^}]*)\}/s)
?.groups.body || '';
const typeActionButtonRule = css.match(
/\.candidateTypeAction \.candidateTypeSwitch button\s*\{(?<body>[^}]*)\}/s
)?.groups.body || '';

assert.match(groupSource, /aria-controls=\{disclosureId\}/);
assert.match(groupSource, /aria-expanded=\{expanded\}/);
Expand Down Expand Up @@ -467,9 +472,13 @@ test('import candidate groups disclose locations and use radio variant selection
assert.match(disclosureRule, /display:\s*inline-flex;/);
assert.match(locationRule, /grid-template-columns:\s*96px minmax\(0,\s*1fr\);/);
assert.match(typeActionRule, /display:\s*grid;/);
assert.match(typeActionRule, /min-width:\s*142px;/);
assert.match(typeActionRule, /width:\s*208px;/);
assert.match(typeActionRule, /box-sizing:\s*border-box;/);
assert.match(typeActionRule, /justify-self:\s*end;/);
assert.match(requiredTypeActionRule, /border-color:\s*var\(--skillbox-amber-border\);/);
assert.match(requiredTypeActionRule, /background:\s*var\(--skillbox-surface-orange\);/);
assert.match(typeActionSwitchRule, /width:\s*100%;/);
assert.match(typeActionButtonRule, /flex:\s*1 1 0;/);
});

test('import review uses the shared searchable candidate list template', () => {
Expand Down
14 changes: 13 additions & 1 deletion apps/desktop/src/styles.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6597,7 +6597,9 @@ dd {

.candidateTypeAction {
display: grid;
min-width: 142px;
width: 208px;
box-sizing: border-box;
justify-self: end;
justify-items: start;
gap: 5px;
border: 1px solid transparent;
Expand Down Expand Up @@ -6635,6 +6637,15 @@ dd {
line-height: 1.35;
}

.candidateTypeAction .candidateTypeSwitch {
width: 100%;
}

.candidateTypeAction .candidateTypeSwitch button {
min-width: 0;
flex: 1 1 0;
}

.importSheetFooter {
align-items: center;
border-top: 1px solid var(--skillbox-slate-bg);
Expand Down Expand Up @@ -6979,6 +6990,7 @@ dd {
.candidateTypeAction {
grid-column: 2;
width: min(100%, 320px);
justify-self: start;
}

.candidateLocation {
Expand Down