Force delete share type extra specs - #351
Open
kpawar-sap wants to merge 2 commits into
Open
kpawar-sap wants to merge 2 commits into
kpawar-sap wants to merge 2 commits into
Conversation
kpawar-sap
requested review from
Carthaca,
chuan137,
crenduchinta88,
skook1 and
sumitarora2786
as code owners
August 13, 2026 12:52
Author
|
seems this change is causing regression new PR https://review.opendev.org/c/openstack/manila/+/1000930. onc emerged upstram i will merge here too. till hold this PR |
Author
|
ready to review |
Collaborator
|
We need to modify our share types with extra spec |
The force delete in upstream is done using share type extra spec while sapcc is using config option. Remove CONF.force_delete_time and move the logic to share type extra specs. Change-Id: I32aa98a75663f61bde9cb5b3385cc35cde59100b
The force-delete extra-spec feature added an unconditional share_types.get_extra_specs_from_share(share) call in _delete_share(), which needs share['share_type_id']. The synthetic share dict used to track the temporary source clone during cross-AZ/cross-backend create-from-snapshot never carried a share_type_id, causing: manila.exception.InvalidShareType: Invalid share type: id cannot be None. Fix: * Populate 'share_type_id' in the synthetic share dict. * Skip the extra specs lookup in _delete_share() when share_type_id is missing, instead of raising. Closes-Bug: #2163563 Signed-off-by: Medha Choudhary <medhac@netapp.com> Assisted-By: GitHub Copilot Co-authored-by: Copilot <copilot@github.com> Change-Id: Id7f303d3b07c4efb5d345d115069c3f393d33695 (cherry picked from commit 3be932e)
kpawar-sap
force-pushed
the
force_delete_share_type_extra_spec
branch
from
September 10, 2026 12:54
04a8153 to
310801d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The force delete in upstream is done using share type extra spec while sapcc is using config option. Remove CONF.force_delete_time and move the logic to share type extra specs.
Change-Id: I32aa98a75663f61bde9cb5b3385cc35cde59100b