Conversation
Carthaca
requested review from
chuan137,
crenduchinta88,
kpawar-sap,
skook1 and
sumitarora2786
as code owners
September 9, 2026 11:12
Carthaca
marked this pull request as draft
September 9, 2026 11:12
|
After checking you comment on #355 , I did file by file compare and update PR since earlier was with claude. |
Collaborator
Author
|
yeah, I also delegated this to claude and I'm not yet happy with the results |
Carthaca
force-pushed
the
test/share-server-replica-maurice
branch
from
September 9, 2026 14:13
474dba8 to
1f20664
Compare
Added Share Server Replica APIs enabling replication of entire share servers across backends for disaster recovery, with support for create, list, show, delete, promote, resync, and metadata operations. Backported from Gerrit change 993501 (patchset 83) onto stable/2025.1-m3. Migration-style controller changes were dropped to match this branch's pre-migration API generation; SSR bits were grafted onto the existing old-style share controller. API microversion kept at 2.100 to match the SSR controller and upstream. Change-Id: Idb0bbed72e00527d2b675853656317ce00cec812 Signed-off-by: agireesh <gawasthi2010@gmail.com> Signed-off-by: manideepn <manideep.openstack@gmail.com> Signed-off-by: Maurice Escher <maurice.escher@sap.com> Assisted-By: Claude Sonnet 4.6, Claude Code Sonnet 5
Depends-on: https://review.opendev.org/c/openstack/manila/+/993501 Backported from Gerrit change 991844 (patchset 53) onto stable/2025.1-m3. Resolved conflicts against the base NetApp driver: kept base's _get_or_create_ipspace and /cluster/nodes version query, preserved SAP-only driver tests, and reconciled the SM-as tests with the base driver generation. Change-Id: Ifd27ac55c211f552fa802d56823e901bf557ff5b Signed-off-by: Kumar Tadepalli <kumart.lead@gmail.com> Signed-off-by: Sanketh Shetty <sanketh.shetty@netapp.com> Signed-off-by: Maurice Escher <maurice.escher@sap.com> Assisted-By: Claude Code Opus 5
Depends-on: https://review.opendev.org/c/openstack/manila/+/991844 Backported from Gerrit change 996629 (patchset 30) onto stable/2025.1-m3. Reconciled with SAP customizations: kept the CONF.force_delete_time force-delete behavior (added upstream's private_storage cleanup), restored the DNS reconciliation feature that the merge dropped, and preserved the SCI logical-space / cross-volume-dedupe options alongside the new SMAS protection hooks. Change-Id: Ica99f990a1d6c14e7ee29fb9acd6ff986eb28adc Signed-off-by: Kumar Tadepalli <kumart.lead@gmail.com> Signed-off-by: Sanketh Shetty <sanketh.shetty@netapp.com> Signed-off-by: Maurice Escher <maurice.escher@sap.com> Assisted-By: Claude Code Opus 5
Carthaca
force-pushed
the
test/share-server-replica-maurice
branch
from
September 10, 2026 12:25
1f20664 to
bef1abc
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fresh backport, because #355 was taking me down a rabbit hole