scheduler: clear snapshot_id from replica request_spec - #367
Open
kpawar-sap wants to merge 1 commit into
Open
kpawar-sap wants to merge 1 commit into
kpawar-sap wants to merge 1 commit into
Conversation
kpawar-sap
requested review from
Carthaca,
chuan137,
crenduchinta88,
skook1 and
sumitarora2786
as code owners
September 14, 2026 13:34
Author
|
Removing snapshot_id from request_spec has additional following changes . create_from_snapshot.py filter — snapshot_id=None → returns True (all hosts pass). This is correct — a replica is not being created from a snapshot, it's host_affinity.py weigher — snapshot_id=None → returns 0, no DB lookup. Previously it would fetch the snapshot from DB and steer the replica toward the |
A share created from a snapshot carries snapshot_id, which the capacity filter and weigher use to apply reserved_snapshot_percentage instead of reserved_percentage, and which the host-affinity weigher uses to steer scheduling toward the snapshot's source host. Neither behaviour is appropriate for replica scheduling: replicas are intentionally placed on a different backend, so reserved_snapshot_percentage (meant to keep snapshot-derived shares near their parent) is wrong, and affinity toward the original snapshot host is actively harmful. Change-Id: I9ba703dc38c6d9630174dad7ab4faf6270360d3a
kpawar-sap
force-pushed
the
fix_share_reserver_precentage_for_replica
branch
from
September 14, 2026 14:22
94683bc to
3fe4479
Compare
Carthaca
approved these changes
Sep 14, 2026
Author
|
lets wait for a some-time for review on upstream PR https://review.opendev.org/c/openstack/manila/+/1005578 |
Collaborator
|
ack |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A share created from a snapshot carries snapshot_id, which the capacity filter and weigher use to apply reserved_snapshot_percentage instead of reserved_percentage, and which the host-affinity weigher uses to steer scheduling toward the snapshot's source host.
Neither behaviour is appropriate for replica scheduling: replicas are intentionally placed on a different backend, so reserved_snapshot_percentage (meant to keep snapshot-derived shares near their parent) is wrong, and affinity toward the original snapshot host is actively harmful.
Change-Id: I9ba703dc38c6d9630174dad7ab4faf6270360d3a