Skip to content

Do not bind VM ports directly #141

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
fwiesel wants to merge 1 commit into
base: stable/yoga-m3
Choose a base branch
from
Draft

Do not bind VM ports directly #141

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 19 additions & 2 deletions networking_ccloud/ml2/mech_driver.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -122,6 +122,23 @@ def get_workers(self):
"""
return [service.RpcWorker([self], worker_process_count=0)]

def _should_bind_directly(self, context, hg_config):
# No direct binding here
if not hg_config.direct_binding:
return False

# Now we likely want a direct binding, unless the binding request
# comes for a VM on the given host
port = context.current
# We only want to override it for compute
device_owner = port.get('device_owner', None)
if not device_owner or not device_owner.startswith(
nl_const.DEVICE_OWNER_COMPUTE_PREFIX):
return

# So, it is for nova. We only do direct bindings for ironic.
return port.get(pb_api.VNIC_TYPE) == pb_api.VNIC_BAREMETAL

def bind_port(self, context):
"""Attempt to bind a port.

Expand Down Expand Up @@ -187,7 +204,7 @@ def bind_port(self, context):
if not context.binding_levels:
# Port has not been bound to any segment --> top level binding --> hpb
self._bind_port_hierarchical(context, binding_host, hg_config)
elif hg_config.direct_binding:
elif self._should_bind_directly(context, hg_config):
self._bind_port_direct(context, binding_host, hg_config)

def _bind_port_hierarchical(self, context, binding_host, hg_config):
Expand All @@ -213,7 +230,7 @@ def _bind_port_hierarchical(self, context, binding_host, hg_config):
next_segment = context.allocate_dynamic_segment(segment_spec)

# config update (direct bindings are handled in the next step)
if not hg_config.direct_binding:
if not self._should_bind_directly(context, hg_config):
# send rpc call to agent
net_external = context.network.current[extnet_api.EXTERNAL]
self.handle_binding_host_changed(context._plugin_context, context.current['network_id'],
Expand Down