Conversation
sebageek
changed the title
sebageek
force-pushed
the
config-gen-manila-support
branch
from
August 26, 2026 11:31
908fdcf to
86b9167
Compare
Loadbalancer requires some more handling on device discovery. As we need to do something similar for manila we move the code for loadbalancers into its own method to unclutter get_connected_devices() a bit.
With manila the individual node servers are directly connected to the switch in NetBox. Neither the devices nor the parent device have any cluster config whatsoever. To find all devices we need to find the parent device via parent_bay and then look at all the devicebays from there (close, but not similar to how we handle loadbalancers). We also filter on the manila tag being present on the parent device.
sebageek
force-pushed
the
config-gen-manila-support
branch
from
September 14, 2026 14:50
86b9167 to
f98a845
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
With manila the individual node servers are directly connected to the
switch in NetBox. Neither the devices nor the parent device have any
cluster config whatsoever. To find all devices we need to find the
parent device via parent_bay and then look at all the devicebays from
there (close, but not similar to how we handle loadbalancers). We also
filter on the manila tag being present on the parent device.