Use context provided by request - #121
Open
sven-rosenzweig wants to merge 3 commits into
Open
sven-rosenzweig wants to merge 3 commits into
sven-rosenzweig wants to merge 3 commits into
Conversation
sven-rosenzweig
force-pushed
the
context_aware_logging
branch
3 times, most recently
from
August 15, 2023 13:24
1c23104 to
6ebd039
Compare
Scoping all API and RPC calls to the same context makes debugging far easier since the request will be logged. Oslo_log tries to extract the context either by explicit passing to the logger or taking it from the thread-local store. The latter does not work since some of the requests enter a queue before being processed by a different thread. Therefore the context is passed in job entering the queue and passed to every log line necessary.
sven-rosenzweig
force-pushed
the
context_aware_logging
branch
from
August 15, 2023 14:08
6ebd039 to
e16c94e
Compare
|
sven-rosenzweig
force-pushed
the
context_aware_logging
branch
from
August 16, 2023 11:32
cf0036f to
ae333f9
Compare
Calls, initially started from the driver, made from the agent to neutron server also used a one-time created context instead of the context associated with the call, leading to one single request id for all calls made by the agent, instead of them being tied to a client request for which they were made. For calls, made from the agent to neutron server initially triggered by the sync-loop, still use the one-time created context.
sven-rosenzweig
force-pushed
the
context_aware_logging
branch
from
August 16, 2023 11:51
ae333f9 to
9929c97
Compare
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Scoping all API and RPC calls to the same context makes debugging far easier since the request id will be logged by the agent.
Oslo_log tries to extract the context either by explicit passing to the logger or taking it from the thread-local store. The latter does not work since some of the requests enter a queue before being processed by a different thread. Therefore the context is passed in job entering the queue and passed to every log line necessary.