Extend AffinityWeigher to support shards. - #306
Open
kpawar-sap wants to merge 1 commit into
Open
kpawar-sap wants to merge 1 commit into
kpawar-sap wants to merge 1 commit into
Conversation
joker-at-work
marked this pull request as draft
February 11, 2022 08:20
kpawar-sap
force-pushed
the
update_affinity_weighter
branch
2 times, most recently
from
February 11, 2022 10:41
99358ad to
2a8b8ae
Compare
Author
|
Handled if weight < 1 is returned from _weigh_object, in case of ServerGroupSoftAntiAffinityWeigher. |
kpawar-sap
force-pushed
the
update_affinity_weighter
branch
from
February 11, 2022 15:34
2a8b8ae to
c1d1de9
Compare
joker-at-work
left a comment
joker-at-work
left a comment
There was a problem hiding this comment.
Just a quick glance over the code.
kpawar-sap
force-pushed
the
update_affinity_weighter
branch
2 times, most recently
from
February 15, 2022 04:13
693ead9 to
d6e7286
Compare
joker-at-work
requested changes
Feb 18, 2022
kpawar-sap
force-pushed
the
update_affinity_weighter
branch
from
February 18, 2022 16:20
d6e7286 to
5e58575
Compare
kpawar-sap
changed the title
ServerGroupAffinityWeigher gives back a high weight if the compute node already contains servers of the same server-group. However, we want to add a semi-high weight when other compute nodes in the same shard contain servers of this server-group. Usecase is to give the user a way to schedule servers to the same shard based on previously spawned servers e.g. to replace them with the new ones. If the servers are in the same shard, there's no automatic volume-migration happening.
kpawar-sap
force-pushed
the
update_affinity_weighter
branch
from
March 10, 2022 11:27
5e58575 to
defc432
Compare
kpawar-sap
marked this pull request as ready for review
March 10, 2022 11:31
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ServerGroupAffinityWeigher gives back a high weight if the compute node
already contains servers of the same server-group. However, we want to
add a semi-high weight when other compute nodes in the same shard
contain servers of this server-group.
Usecase is to give the user a way to schedule servers to the same shard
based on previously spawned servers e.g. to replace them with the new
ones. If the servers are in the same shard, there's no automatic
volume-migration happening.