fix(web): keep dashboard chrome pinned when modals scroll-lock body - #4
Merged
Conversation
Sticky sidebar/header un-stick mid-scroll when a modal scroll-locks <body>, since that turns the body into a scroll container. Make the shell own scrolling instead: fixed-height layout, Content scrolls.
sardorml
marked this pull request as ready for review
July 10, 2026 06:26
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Opening a modal on the dashboard scroll-locks
<body>, which turns the body into a scroll container and un-sticks the sticky sidebar/header mid-scroll — the dashboard chrome visibly jumps.Fix
Make the shell own scrolling instead of relying on sticky-in-document-scroll:
Layoutis fixed atheight: 100vh(wasminHeight)SiderandHeaderdrop theirposition: stickystyles — they're pinned by the layout itselfContentbecomes the scroll container (overflowY: auto)LayoutgetsminWidth: 0so it can shrink within the flex rowModal scroll-locking now affects nothing, since the body never scrolls.
Testing
pnpm typecheckgreenpnpm --filter @captureflow/web test— 26/26 pass