refactor: enhance SDK with required change and bug fixes#117
Merged
sarvalabs-gokul merged 728 commits intosarvalabs:implement/v0.7.0from Apr 30, 2025
Merged
refactor: enhance SDK with required change and bug fixes#117sarvalabs-gokul merged 728 commits intosarvalabs:implement/v0.7.0from
sarvalabs-gokul merged 728 commits intosarvalabs:implement/v0.7.0from
Conversation
…tations for consistency
…uest method signature
…e package dependencies
- Introduced a new enum `Chain` with values for Testnet, Devnet, and Mainnet in `enums.ts`. - Updated the corresponding type definitions and source maps. - Modified the exports in `index.ts` and `index.d.ts` to include the new `Chain` enum. - Adjusted the generated JavaScript and source maps to reflect the changes.
- Modified the type of `chain_id` in the `NetworkInfo` interface from `number` to `Chain` to ensure type safety and consistency with the updated enums. - Updated import statements to include the `Chain` type from the enums module.
…method - Added a private keyIndex property to the BrowserWallet class. - Modified the constructor to accept WalletOption and initialize keyIndex. - Updated getKeyId method to return the keyIndex directly instead of fetching from the provider. - Adjusted type definitions and documentation accordingly.
fix(errors): update errors.d.ts and errors.js.map to reflect new error code chore(wallet): change getKeyId method visibility to public in BrowserWallet class chore(wallet): update browser-wallet.d.ts and browser-wallet.js.map for consistency chore(wallet): regenerate source maps for browser-wallet
- Deleted the getWalletPublicKey method and its associated documentation from the BrowserProvider class in both TypeScript and JavaScript files. - Updated the corresponding type definitions and source maps to reflect the removal of this method.
- Introduced a new SubAccount interface with inherited_account and accounts properties. - Updated AccountMetaData to include an array of sub_accounts of type SubAccount. - Modified related TypeScript definitions in responses.d.ts and responses.ts. - Updated index.ts to export new types related to account inheritance.
…ORTED error code - Renamed TimerOption to WaitOption in interaction-response utility. - Updated methods in InteractionResponse class to accommodate new WaitOption structure. - Added optional properties to WaitOption for retries, delayInSec, and signal. - Introduced ACTION_ABORTED error code in ErrorCode enum for better error handling.
sarvalabs-harshrastogi
changed the base branch from
develop
to
implement/v0.7.0
sarvalabs-harshrastogi
added
bug
sarvalabs-gokul
approved these changes
Apr 30, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Enhance SDK and Resolve Bugs
This pull request enhance SDK, remove bugs, update type. That were found while during the development of MOI Wallet and Voyage Development.
Changes:
waitoperation while waiting for interaction to cancel.Chainfor chain ID