β‘ Bolt: Optimize candidate filtering by removing unnecessary clones #3
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
π‘ What: Refactored the
Filtertrait and its implementations to return original candidates upon error, eliminating the need for preemptive cloning in the pipeline loop.π― Why:
candidates.clone()was being called for every filter in the pipeline as a recovery mechanism. Since candidates are large vectors of complex structs, this was a significant performance bottleneck.π Impact: Eliminates N clones per request where N is the number of filters (currently ~12). This should significantly reduce CPU usage and memory allocations.
π¬ Measurement: Verify that the pipeline still functions correctly and handles errors (if any) by restoring candidates.
PR created automatically by Jules for task 3257336148489922122 started by @sashimikun