fix(test): bumped Node to lts/iron (v20.x.x) for tests#410
Merged
Conversation
mulahasanovic
approved these changes
Dec 11, 2025
|
🎉 This PR is included in version 4.59.10 🎉 The release is available on: Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue
Tests are using an end-of-life version of Node.
@sasjs/cli does not reference the @sasjs/core branch under test during the test workflow.
Intent
Use the oldest supported version of Node for testing.
Set environment variable
macroCorePathto direct @sasjs/cli to use the installation of@sasjs/coreat the path provided in that variable. The variable is set to.to denote the current directory which, at time of execution, is the root folder of the@sasjs/corebranch being tested.Implementation
run-tests.yml: amended node-version from[lts/hydrogen]to[lts/iron].run-tests.yml: amendedbecomes
Checks
sasjs lint).sasjs test).