Refactor Easing functions with internal _Raw methods - #49
Refactor Easing functions with internal _Raw methods#49google-labs-jules[bot] wants to merge 1 commit into
Conversation
…methods.
- Declared internal <Method>_Raw methods with AggressiveInlining for all easing types.
- Organized methods as 3 public methods followed by 3 internal _Raw methods for each category.
- Updated public methods to call corresponding _Raw methods without 0-1 boundary guards for verification.
- Removed unnecessary guards from _Raw methods, keeping only those part of the original formula (e.g., Expo, Elastic).
- Updated ExpectedValueGenerator.cs to use _Raw methods directly.
- Added InternalsVisibleTo("ExpectedValueGenerator") in AssemblyInfo.cs.
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
This refactor separates the core mathematical formulas of all easing functions into internal, inlined
_Rawmethods.Key changes:
QuadIn) now has a correspondingQuadIn_Rawinternal method._Rawmethods per easing category.x <= 0 ? 0 : (x >= 1 ? 1 : ...)guards were removed from the_Rawmethods to use the "original formula".ExpoandElasticstability at_Rawmethods._Rawmethods without extra guards (per verification requirements).ExpectedValueGenerator.csat the repository root now uses these internal_Rawmethods instead of having its own duplicate implementations, ensuring it generates values based on the actual library logic._Rawmethods use[MethodImpl(MethodImplOptions.AggressiveInlining)].AssemblyInfo.cswas updated to grantExpectedValueGeneratoraccess to internal members.Note: As per explicit instructions, public methods currently lack 0-1 clamping, which is expected to cause test failures at$t=0$ and $t=1$ in the current project state for implementation verification.
PR created automatically by Jules for task 15911222361911213953 started by @sator-imaging