fix: move wallet extension detection into useWallets hook#68
Merged
satoshai-dev merged 1 commit intomainfrom Apr 6, 2026
Merged
fix: move wallet extension detection into useWallets hook#68satoshai-dev merged 1 commit intomainfrom
satoshai-dev merged 1 commit intomainfrom
Conversation
Instead of relying solely on the provider's render-time detection (which can miss extensions that inject after React hydration), useWallets now calls getStacksWallets() directly on every render. This ensures fresh detection at the point of consumption — by the time a user opens a connect-wallet drawer, extensions are detected. Reverts the provider-level useState/useEffect approach from #66 in favor of this simpler hook-level solution. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
satoshai-dev
force-pushed
the
fix/wallet-detection-at-hook-level
branch
from
e2326d3 to
d6df3e1
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
useWalletsnow callsgetStacksWallets()directly on every render, merging fresh window-global detection with the provider's configured wallet listuseState/useEffectapproach from fix: re-check installed wallets after mount for late-injecting extensions #66 in favor of this simpler hook-level solutionavailableflag with fresh detectionTest plan
useWalletstests, 2 updated provider tests)pnpm build)