Repository navigation
Conversation
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
… card Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
…trait and landscape layouts Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
This was referenced Nov 8, 2026
ricaezejo
force-pushed
the
feat/fullscreen-route-map
branch
from
November 8, 2026 21:44
dfba02a to
f46d86d
Compare
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
ricaezejo
marked this pull request as ready for review
November 13, 2026 09:00
| */ | ||
| internal fun kmMarkerBitmap(km: Int, density: Float): Bitmap { | ||
| val size = (22 * density).toInt() | ||
| val bitmap = Bitmap.createBitmap(size, size, Bitmap.Config.ARGB_8888) |
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Tapping the Route card on a finished GPS workout now opens the map full screen.
Route.legsis the single source of kilometres;Route.splitsnow delegates to it so markers, highlight and the Splits list cannot disagree.Where the map's state lives
Which workout's map is open, Route only and the selected split are kept in an activity-scoped
RouteMapModel(ViewModel), and the dialog is hosted at page level. NotrememberSaveable:FullScreenRouteMapRotationTest).rememberSaveablein the card failed too: portrait and landscape place the page at different positions in the layout tree, so each orientation kept its own copy and a stale one could bring a closed map back.The dialog's entrance animation is turned off best-effort so a rotation doesn't replay it.
No new permissions or network use.
This is the lower PR of a stack; the GPX export PR builds on it.
Known limits
Test plan
./gradlew :app:testDebugUnitTest :protocol:test :app:lintDebug detektMain.ktlintCheckreports findings across the repo (it iscontinue-on-errorin CI).