Repository navigation
The week view shows the days after the one shown (#66 I9) - #68
Merged
Merged
Conversation
Opened from a past day, Your week had no active minutes or sleep for the days after it: both are worked out or loaded only up to the day shown. It now also reads the week as its last day has it, and fills those days in. Issue #66, I9. Co-Authored-By: Claude Fable 5.2 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What was wrong
Open Your week from a past day in the middle of a week, and the days after it had no active minutes and no sleep. Steps showed for every day.
The fix
The week view now also reads the week as its last day has it (today, for this week) and fills in the later days.
DayViewModel.weekThrough(end)gives each day's active minutes from the result forend, and the nights as of the morning afterend, or today.WeekDetailuses it only when the day shown is before today. Days up to the one shown keep their own numbers, so they match the rest of the app.Checked
Last open item from #66 that was planned to be fixed.