Skip to content

fix: moving components#5

Merged
sbaiahmed1 merged 1 commit intomainfrom
feature/fix_moving_component
Oct 29, 2025
Merged

fix: moving components#5
sbaiahmed1 merged 1 commit intomainfrom
feature/fix_moving_component

Conversation

@florismettey
Copy link
Copy Markdown
Collaborator

@florismettey florismettey commented Oct 29, 2025

Summary by Sourcery

Simplify setupChildViewAsMenuTrigger by removing manual layout constraints and only attaching menu triggers for UIButton views.

Bug Fixes:

  • Prevent layout conflicts by eliminating redundant constraint modifications in the menu trigger setup

Enhancements:

  • Remove manual constraint removal and activation logic from setupChildViewAsMenuTrigger
  • Rely on React’s mounting for child view insertion instead of adding constraints in native code

@sourcery-ai
Copy link
Copy Markdown

sourcery-ai bot commented Oct 29, 2025

Reviewer's guide (collapsed on small PRs)

Reviewer's Guide

The PR simplifies the native MenuView setup by removing manual constraint management in setupChildViewAsMenuTrigger and focusing solely on attaching the menu to UIButton children.

Class diagram for updated MenuView setupChildViewAsMenuTrigger method

classDiagram
class MenuView {
  - UIView<RCTComponentViewProtocol> childComponentView
  - UIButton _menuButton
  + unmountChildComponentView(childComponentView)
  + setupChildViewAsMenuTrigger(childView)
}
class UIButton
MenuView --> UIButton : attaches menu if childView is UIButton
Loading

File-Level Changes

Change Details Files
Simplify setupChildViewAsMenuTrigger by removing manual constraint logic
  • Removed translatesAutoresizingMaskIntoConstraints setup
  • Dropped removal of existing constraints
  • Deleted explicit fill-to-parent anchor activation
  • Retained only UIButton check to attach the menu
ios/MenuView.mm

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

Copy link
Copy Markdown

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey there - I've reviewed your changes and they look great!


Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

@sbaiahmed1 sbaiahmed1 self-assigned this Oct 29, 2025
@sbaiahmed1 sbaiahmed1 added the bug Something isn't working label Oct 29, 2025
@sbaiahmed1 sbaiahmed1 self-requested a review October 29, 2025 11:03
@sbaiahmed1 sbaiahmed1 merged commit 01d8cb6 into main Oct 29, 2025
6 checks passed
@sbaiahmed1 sbaiahmed1 deleted the feature/fix_moving_component branch October 29, 2025 11:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants