ci: Use sbt 1.x to build + migrate the driver to Scala 2.12 - #244
Merged
Merged
Conversation
eed3si9n
marked this pull request as draft
August 27, 2026 03:44
eed3si9n
changed the title
eed3si9n
marked this pull request as ready for review
August 27, 2026 05:21
SethTisue
reviewed
Aug 27, 2026
SethTisue
left a comment
SethTisue
left a comment
Contributor
There was a problem hiding this comment.
one question, otherwise LGTM
| @@ -1,2 +1,2 @@ | |||
| // This is a bit circular, indeed. But why not? | |||
| libraryDependencies += "com.typesafe.dbuild" %% "http" % "0.9.9" | |||
| // libraryDependencies += "com.typesafe.dbuild" %% "http" % "0.9.9" | |||
Contributor
There was a problem hiding this comment.
"leave in or delete — there is no comment out" — Yoda
do we know what this is or was for?
Contributor
Author
There was a problem hiding this comment.
I think it was used to pull in Dispatch to sbt 0.13. I'll remove it.
Contributor
|
about sbt 0.13, the support is still used in the Scala 2.12 community build, but not in the 2.13 build. but the 2.12 build is frozen and will never need to support sbt 2, so it will never need to move to newer dbuild therefore, you're free to drop sbt 0.13.18 support if it's getting in the way at all |
Contributor
Author
Yea, in the sbt 2.x branch I've dropped sbt 0.13 support. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Dbuild consists of the driver program and sbt plugin(s) that get injected into the repo under build.
Currently the driver program is written in Scala 2.10 and the plugins are cross built against sbt 0.13 and sbt 1.x.
Solution
As a prep step towards modernization, this migrates the driver as well as well as the build definition to sbt 1.x, which is capable of cross building to sbt 2.x.