Repository navigation
Support method signatures to distinguish overloads in filters - #985
Merged
Merged
Conversation
lrytz
force-pushed
the
keep-signature
branch
2 times, most recently
from
September 17, 2026 12:55
cd7955a to
a230a2f
Compare
lrytz
changed the title
lrytz
force-pushed
the
keep-signature
branch
2 times, most recently
from
September 17, 2026 19:57
ad6cbf3 to
c8b8f56
Compare
A filter or `mimaBinaryApi` entry naming a method, such as `foo.C.f`, applies to every overload of `f`. A keep entry then put overloads back under mima's watch that were never part of the API, and reported their long-ago removal; pekko hit this on its first entry. A name can now include the signature the report prints, `foo.C.f(Int)Int`, and then names that one method. Reports suggest that form. A name without a signature still covers every overload, so existing filters are unaffected. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
lrytz
force-pushed
the
keep-signature
branch
2 times, most recently
from
September 18, 2026 06:01
b0295d3 to
5c3cf5a
Compare
lrytz
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A filter or
mimaBinaryApientry naming a method, such asfoo.C.f, applies to every overload off. Akeepreaching too many overloads can put methods under mima's watch that were never part of the API (pekko hit this).lA name can now include the signature,
foo.C.f(Int)Int. Reports suggest that form. A name without a signature still covers every overload, so existing filters are unaffected.