Repository navigation
CLI: fix exit codes, -s to show filter suggestions - #989
Merged
Merged
Conversation
The exit code was the number of problems, which a shell truncates to one byte, so 256 problems looked like success. A missing oldfile or newfile printed an error and exited 0, so a script could not tell it from a clean run. The CLI now exits 1 on problems and 2 on a usage error. A problem printed the name of a method without its signature, so overloads were indistinguishable, and the line no longer matched the filter to paste for it. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
The sbt plugin printed the lines to paste into a build; the CLI printed only the problems. The lines now come from ProblemSuggestions in core, so both tools say the same thing, and the CLI prints them with -s. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.