fix(core): preserve original error cause chain in getModule#165
Merged
fix(core): preserve original error cause chain in getModule#165
Conversation
|
View your CI Pipeline Execution ↗ for commit eb9af3b
☁️ Nx Cloud last updated this comment at |
The catch block in getModule was swallowing the original ErrorWithCause from the dynamic-plugin-sdk and replacing it with a generic message, making it impossible to diagnose federated module loading failures. Also improves error messages when a scope is missing from the scalprum config by listing available scopes. Resolves: RHCLOUD-47479 Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Hyperkid123
force-pushed
the
fix/preserve-original-error-in-getModule
branch
from
1d5acd1 to
eb9af3b
Compare
karelhala
approved these changes
May 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
try/catchingetModulethat was swallowing the originalErrorWithCausefrom@openshift/dynamic-plugin-sdkand replacing it with a generic"Module not initialized!"messagegetModuleandpreloadModule— when a scope isn't in the scalprum config, the error now lists all available scopesmanifestLocationResolves RHCLOUD-47479
Test plan
🤖 Generated with Claude Code