Added Item and Menu managers and updated their models#26
Open
denisprotassoff wants to merge 6 commits into
Open
Added Item and Menu managers and updated their models#26denisprotassoff wants to merge 6 commits into
denisprotassoff wants to merge 6 commits into
Conversation
AleksandrsKondratjevs
approved these changes
Dec 13, 2022
Member
AleksandrsKondratjevs
left a comment
AleksandrsKondratjevs
left a comment
There was a problem hiding this comment.
LGFM, but fix please docblocks
Comment on lines
+6
to
+11
| /** | ||
| * @category ScandiPWA | ||
| * @package ScandiPWA\MenuOrganizer\Api | ||
| * @author Vladislavs Zimnikovs <info@scandiweb.com> | ||
| * @copyright Copyright (c) 2022 Scandiweb, Ltd (http://scandiweb.com) | ||
| * @license http://opensource.org/licenses/afl-3.0.php Academic Free License (AFL 3.0) |
There was a problem hiding this comment.
Doc block not in the correct position. Should be at begging.
Comment on lines
+6
to
+11
| /** | ||
| * @category ScandiPWA | ||
| * @package ScandiPWA\MenuOrganizer\Api | ||
| * @author Vladislavs Zimnikovs <info@scandiweb.com> | ||
| * @copyright Copyright (c) 2022 Scandiweb, Ltd (http://scandiweb.com) | ||
| * @license http://opensource.org/licenses/afl-3.0.php Academic Free License (AFL 3.0) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.