Repository navigation
CI: run validate, test and tsc on pull requests and main - #15
Merged
Merged
Conversation
One workflow, no secrets. Claude Code 2.1.309 is installed from npm and TypeScript 7.0.2 is pinned. tsc needs .claude-plugin/types/, which only an interactive --plugin-dir load writes, so the workflow starts one under script with a throwaway config (onboarding done, folder trusted), waits for the types, stops it and checks they came from the pinned version. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
scasella
marked this pull request as ready for review
October 24, 2026 11:41
A run on main is kept even when another merge lands behind it, so every commit on main ends with a completed check. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Outside pull requests (#10, #11, #12) reported passing checks, but nothing verified them. This adds one workflow,
.github/workflows/ci.yml, that runs the three checks CONTRIBUTING.md requires on every pull request and on each push tomain:claude plugin validate .claude plugin test .npx -p typescript tsc -p .Green run on this branch (
772ea5e): https://github.com/scasella/claude-flightdeck/actions/runs/40091015254 (the first commit's run, https://github.com/scasella/claude-flightdeck/actions/runs/40090843947, was green too). CLI 2.1.309, validate passed (only the existing icon warning), 46/46 tests, types written in about 2s, tsc clean, no orphan processes at cleanup.How it works
npm install -g @anthropic-ai/claude-code@2.1.309on Node 24. The npm package installs the native linux-x64 binary as an optional dependency, and npm checks its integrity.setup-nodecaches~/.npm, keyed on the workflow file, so changing a pinned version busts the cache.DISABLE_AUTOUPDATERandCLAUDE_CODE_DISABLE_NONESSENTIAL_TRAFFICkeep the pinned CLI from updating itself or sending telemetry.plugin validateandplugin testmake no model call; both pass locally with an emptyCLAUDE_CONFIG_DIRand pass here with no secrets. The workflow reads no secrets, hascontents: readonly, and checks out without persisting the token, so fork PRs run it the same way..claude-plugin/types/is written only when an interactive session loads the mod from--plugin-dir. The plugin-authoring reference says a--plugin-dirfolder underclaude -p"is never written in", which matches what we saw. So the workflow:.claude.json(onboarding done, this folder trusted), so the session starts without a login screen or trust dialog;claude --plugin-dir .under util-linuxscript(a pty), with stdin held open, in its own process group;tsconfig.jsonand the threeindex.d.tsfiles (locally they appear in about 2s), then kills the group;Written by Claude Code 2.1.309., and prints the session's screen when that check fails, so a new first-run dialog in a later CLI shows up in the log.npx -p typescriptstays as it is for people running it locally.To move to a newer Claude Code or TypeScript, change
CLAUDE_CODE_VERSIONorTYPESCRIPT_VERSIONat the top of the workflow.Not verified before merge
push: maintrigger first runs once this is merged. The job is the same one as on the pull request.CONTRIBUTING.md gets one line saying CI runs the three checks. Hooks, tests and README are not touched.
🤖 Generated with Claude Code