Repository navigation
Scope the session.append hook to response rows - #21
Open
jeanfbrito wants to merge 1 commit into
Open
jeanfbrito wants to merge 1 commit into
jeanfbrito wants to merge 1 commit into
Conversation
cc-plugin-sec-default passes user plugins over on the attachment, hook-context and compaction doors. The hook reads only assistant rows, which come through the response door.
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
On a Team or Enterprise organization, Claude Code seats its built-in
cc-plugin-sec-defaultplugin outermost. That plugin passes the plugins a person installs over on some events, which includesession.appendrows that come in through theattachment,hook-contextandcompactiondoors. Flightdeck'ssession.appendhook had no matcher, so the session showed this notice:The hook reads only assistant rows, which come in through the
responsedoor. This change gives the hook a{ door: 'response' }matcher. The hook sees the same rows as before, and it no longer subscribes to the doors that the security plugin passes over.Not in this change
The security plugin also skips the
classic.UserPromptSubmithook, because it passes user plugins over on allclassic.*events. A user-tier plugin cannot skip past a managed tier, so Flightdeck cannot fix this. On such machines the mode field updates only fromagent.spawn. No other event that a user plugin can hook carries the permission mode.Verification
claude plugin validate .passes.claude plugin test .: 50 pass, 0 fail.session.appendnotice. The resumed session appendedhook-contextrows, which caused the notice before the change. Theclassic.UserPromptSubmitnotice still shows, as expected.