Skip to content

chore: upgrade exscalibur - #81

Merged
lukasnehrke merged 1 commit into
mainfrom
chore/update-exscalibur
Jul 16, 2026
Merged

chore: upgrade exscalibur#81
lukasnehrke merged 1 commit into
mainfrom
chore/update-exscalibur

Conversation

@lukasnehrke

@lukasnehrke lukasnehrke commented Jul 16, 2026

Copy link
Copy Markdown
Member

Summary by CodeRabbit

  • Bug Fixes

    • Improved extractor configuration handling so custom settings and ignore patterns are applied more consistently.
    • Added a clear error code when an extractor fails, improving diagnostic reporting.
  • Documentation

    • Clarified CLI help text to show that --ignore patterns apply across all extractors.
  • Improvements

    • Updated analyzer components used by the CLI for improved compatibility and reliability.

@coderabbitai

coderabbitai Bot commented Jul 16, 2026

Copy link
Copy Markdown

Review Change Stack

📝 Walkthrough

Walkthrough

Analyzer dependencies are upgraded, extractor configuration forwarding is simplified, extractor failures gain a stable code, and the CLI help text clarifies that ignore patterns apply to all Exscalibur extractors.

Changes

Extractor configuration alignment

Layer / File(s) Summary
Update analyzer dependencies and extractor handling
packages/cli/package.json, packages/cli/src/exscalibur.ts, packages/cli/src/commands/revisions.ts
Analyzer packages are bumped to 0.1.0-alpha.2; extractor-specific options and conditional ignore settings are passed directly, failures include extractor-failed, and --ignore help text refers to all Exscalibur extractors.

Estimated code review effort: 2 (Simple) | ~10 minutes

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title accurately reflects the main change: upgrading Exscalibur-related CLI dependencies and behavior.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch chore/update-exscalibur

Comment @coderabbitai help to get the list of available commands.

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In `@packages/cli/package.json`:
- Around line 29-33: Resolve the TypeScript peer mismatch in
packages/cli/package.json by either changing the CLI’s typescript dependency
from ^6.0.3 to a supported 5.x release matching the `@scatool/analyzer-`* peer
ranges, or updating those analyzer package peer ranges if TypeScript 6 support
is intentional; ensure all declared versions are compatible.
🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes

ℹ️ Review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: a0882aff-97cf-4699-87ce-c36fb2aa8c76

📥 Commits

Reviewing files that changed from the base of the PR and between 8042064 and c40c666.

⛔ Files ignored due to path filters (1)
  • pnpm-lock.yaml is excluded by !**/pnpm-lock.yaml
📒 Files selected for processing (3)
  • packages/cli/package.json
  • packages/cli/src/commands/revisions.ts
  • packages/cli/src/exscalibur.ts

Comment thread packages/cli/package.json
Comment on lines +29 to +33
"@scatool/analyzer-core": "0.1.0-alpha.2",
"@scatool/analyzer-plugin-go": "0.1.0-alpha.2",
"@scatool/analyzer-plugin-gradle": "0.1.0-alpha.2",
"@scatool/analyzer-plugin-javascript": "0.1.0-alpha.2",
"@scatool/analyzer-plugin-maven": "0.1.0-alpha.2",

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🗄️ Data Integrity & Integration | 🟠 Major | ⚡ Quick win

🧩 Analysis chain

🏁 Script executed:

pnpm view `@scatool/analyzer-core`@0.1.0-alpha.2 peerDependencies
pnpm view `@scatool/analyzer-plugin-javascript`@0.1.0-alpha.2 peerDependencies
pnpm list typescript --filter ./packages/cli

Repository: scatool/cli

Length of output: 835


🏁 Script executed:

#!/bin/bash
set -euo pipefail

printf '\n== packages/cli/package.json ==\n'
sed -n '1,120p' packages/cli/package.json

printf '\n== pnpm-lock.yaml: TypeScript entries ==\n'
rg -n '^(\s*)typescript@|version: .*typescript|typescript:' pnpm-lock.yaml

printf '\n== pnpm-lock.yaml: packages/cli section ==\n'
rg -n 'packages/cli|typescript' pnpm-lock.yaml -A3 -B3

Repository: scatool/cli

Length of output: 16722


Resolve the TypeScript peer mismatch in packages/cli/package.json.
typescript is pinned to ^6.0.3, but the @scatool/analyzer-* packages still declare typescript peers of ^5 / ^5.9.3. Either align the CLI to a supported 5.x release or widen those peer ranges if 6.x is intended.

🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In `@packages/cli/package.json` around lines 29 - 33, Resolve the TypeScript peer
mismatch in packages/cli/package.json by either changing the CLI’s typescript
dependency from ^6.0.3 to a supported 5.x release matching the
`@scatool/analyzer-`* peer ranges, or updating those analyzer package peer ranges
if TypeScript 6 support is intentional; ensure all declared versions are
compatible.

@lukasnehrke
lukasnehrke merged commit 9074c50 into main Jul 16, 2026
5 checks passed
@lukasnehrke
lukasnehrke deleted the chore/update-exscalibur branch July 16, 2026 08:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant