chore: upgrade exscalibur - #81
Conversation
📝 WalkthroughWalkthroughAnalyzer dependencies are upgraded, extractor configuration forwarding is simplified, extractor failures gain a stable code, and the CLI help text clarifies that ignore patterns apply to all Exscalibur extractors. ChangesExtractor configuration alignment
Estimated code review effort: 2 (Simple) | ~10 minutes 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Comment |
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@packages/cli/package.json`:
- Around line 29-33: Resolve the TypeScript peer mismatch in
packages/cli/package.json by either changing the CLI’s typescript dependency
from ^6.0.3 to a supported 5.x release matching the `@scatool/analyzer-`* peer
ranges, or updating those analyzer package peer ranges if TypeScript 6 support
is intentional; ensure all declared versions are compatible.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro Plus
Run ID: a0882aff-97cf-4699-87ce-c36fb2aa8c76
⛔ Files ignored due to path filters (1)
pnpm-lock.yamlis excluded by!**/pnpm-lock.yaml
📒 Files selected for processing (3)
packages/cli/package.jsonpackages/cli/src/commands/revisions.tspackages/cli/src/exscalibur.ts
| "@scatool/analyzer-core": "0.1.0-alpha.2", | ||
| "@scatool/analyzer-plugin-go": "0.1.0-alpha.2", | ||
| "@scatool/analyzer-plugin-gradle": "0.1.0-alpha.2", | ||
| "@scatool/analyzer-plugin-javascript": "0.1.0-alpha.2", | ||
| "@scatool/analyzer-plugin-maven": "0.1.0-alpha.2", |
There was a problem hiding this comment.
🗄️ Data Integrity & Integration | 🟠 Major | ⚡ Quick win
🧩 Analysis chain
🏁 Script executed:
pnpm view `@scatool/analyzer-core`@0.1.0-alpha.2 peerDependencies
pnpm view `@scatool/analyzer-plugin-javascript`@0.1.0-alpha.2 peerDependencies
pnpm list typescript --filter ./packages/cliRepository: scatool/cli
Length of output: 835
🏁 Script executed:
#!/bin/bash
set -euo pipefail
printf '\n== packages/cli/package.json ==\n'
sed -n '1,120p' packages/cli/package.json
printf '\n== pnpm-lock.yaml: TypeScript entries ==\n'
rg -n '^(\s*)typescript@|version: .*typescript|typescript:' pnpm-lock.yaml
printf '\n== pnpm-lock.yaml: packages/cli section ==\n'
rg -n 'packages/cli|typescript' pnpm-lock.yaml -A3 -B3Repository: scatool/cli
Length of output: 16722
Resolve the TypeScript peer mismatch in packages/cli/package.json.
typescript is pinned to ^6.0.3, but the @scatool/analyzer-* packages still declare typescript peers of ^5 / ^5.9.3. Either align the CLI to a supported 5.x release or widen those peer ranges if 6.x is intended.
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
In `@packages/cli/package.json` around lines 29 - 33, Resolve the TypeScript peer
mismatch in packages/cli/package.json by either changing the CLI’s typescript
dependency from ^6.0.3 to a supported 5.x release matching the
`@scatool/analyzer-`* peer ranges, or updating those analyzer package peer ranges
if TypeScript 6 support is intentional; ensure all declared versions are
compatible.
Summary by CodeRabbit
Bug Fixes
Documentation
--ignorepatterns apply across all extractors.Improvements