Artifactory for everyone: ramp to 100 on both channels, and a real off switch - #242
Merged
Merged
Conversation
…f switch The ramp: docs/ramps.json — served at graphcode.app/ramps.json — now lists artifactory at 100/100. It listed nothing before, so every install fell back to the code default of stable:0. Takes effect on each install's next launch, no release needed, and stays the kill switch. FeatureRamps.defaultPercents moves up with it (the codespaces rule: a feature ramped fully on carries its default up, so an offline first launch isn't the one place it's missing). The setting: a switch existed, but as a beta gate — offered only while the ramp was on, and the daemon read an absent key as off. It is a real setting now: always offered, on by default everywhere (GraphcodeSettings .artifactoryEnabled defaults to true, absent key included, so CLI-only machines get the board too), and a person's choice is kept over any later ramp change. Off, the daemon refuses every artifactory verb and the rail section disappears. One switch, not two: the bit the daemon enforces is the setting. Suite: 1497 tests / 155 suites pass; swiftlint 0 errors, format clean. Signed-off-by: scgopi <scgopireddy@gmail.com> Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_019A6NULwEiBXEdRXwEKKcRH
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ships the Artifactory to every install, with a setting for anyone who finds it too much.
The ramp
docs/ramps.json— served atgraphcode.app/ramps.json— now listsartifactoryat 100/100. It listed nothing before, so every install fell back to the code default ofstable: 0. Takes effect on each install's next launch, no release needed; it stays the kill switch.FeatureRamps.defaultPercentsmoves to 100/100 with it — the codespaces rule: a feature ramped fully on carries its default up, so an offline first launch isn't the one place it's missing.The setting
A switch already existed, but it was a beta gate: offered only while the ramp was on, and the daemon read an absent key as off. It is a real setting now:
showsArtifactory/showsSwitchare gone.GraphcodeSettings.artifactoryEnableddefaults totrue, absent key included, so a CLI-only machine or a hand-edited file gets the board the way every install does.One switch, not two: the bit the daemon enforces is the setting, and a second toggle beside it would be two controls for one fact.
Verification
Suite 1497 tests / 155 suites pass; swiftlint 0 errors,
swift-format --strictclean.FeatureRampsTests.artifactoryShipsOnEverywherepins the new default;SettingsArtifactoryTestskeeps pinning choice-outranks-ramp and the kill-switch path.🤖 Generated with Claude Code
https://claude.ai/code/session_019A6NULwEiBXEdRXwEKKcRH