A pane exit never resolves a loop the daemon knows is live or just restarted - #244
Merged
Merged
Conversation
Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_0199VUTtyfuWHbu2hHXpHYw2
…started Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_0199VUTtyfuWHbu2hHXpHYw2
Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_0199VUTtyfuWHbu2hHXpHYw2
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
After Restart All Sessions (0.1.58-beta5), restarted loops showed FAILED. There is exactly one writer of FAILED for an ordinary loop: the app's pane-exit report (
nodeCheckRejected), and the daemon only guarded it for remote projects. A pane that watched a restart's kill, a retained pane of a loop switched away from, or Ghostty's own ⌘W close binding in a running pane could all resolve a loop that was still working. Nothing logged why.What
Daemon
sessionPermitsResolutionreplaces the remote-only check. Refuses a pane exit report within 60 s of a restart (the restart's own kill), or when the local session is still alive and not a husk (ZmxSessionLauncher.isSessionAlive, the ensure's own husk-aware check). Remote keeps its presence check.resolved: failed — its pane closed with the process still running,… — its workers rolled up to stalled,… — its goal predicate passed.App
primarySurfaceExitedlogs apane exit-finished/pane exit-alivedial line and is dropped while a remount is pending. The case moved toAppFeature+LoopSessions.swiftwith its siblings.Verification
swiftlint0 errors;swift format --strictclean.🤖 Generated with Claude Code
https://claude.ai/code/session_0199VUTtyfuWHbu2hHXpHYw2