Artifactory rail: the board takes a share of the rail, never enough to push the foot off - #245
Merged
Merged
Conversation
…o push the foot off Reported: with the summary, the diagram and the board all present, the rail's content can push the lower sections off the bottom of the window. Three flexible sections, two behaviours. The summary and the diagram are greedy (maxHeight .infinity) and yield when squeezed. The board hugs its posts with fixedSize up to a fixed 600pt — rigid — and on a short window that 600, plus THIS LOOP's 118 and the summary's 120 floor, adds up past the rail. A VStack with more rigid content than space overflows, and what slides off is the foot: the button, the footer. The rail now measures its own height with an outer GeometryReader — the container, not a guess from inside a scroll view — and hands the board a cap of 40% of the rail (floor 160, ceiling the old 600). A share cannot overflow on its own, and 40% still shows a conversation. The section takes the cap as a parameter. Suite: 1506 tests / 156 suites pass (+3); swiftlint 0 errors, format clean. Signed-off-by: scgopi <scgopireddy@gmail.com> Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_019A6NULwEiBXEdRXwEKKcRH
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reported: with the summary, the diagram and the board all present, the rail's content can push the lower sections off the bottom of the window.
Cause
Three flexible sections, two behaviours. The summary and the diagram are greedy (
maxHeight: .infinity) — they yield when squeezed. The board hugs its posts withfixedSizeup to a fixed 600pt — it is rigid, and on a short window that 600, plus THIS LOOP's 118 and the summary's 120 floor, adds up past the rail. AVStackwith more rigid content than space overflows, and what slides off is the foot: the button, the footer.Fix
The rail measures its own height with an outer
GeometryReader— the container, not a guess from inside a scroll view — and hands the board a cap of 40% of the rail (floor 160, ceiling the old 600). A share cannot overflow on its own, and 40% still shows a conversation. The section takes the cap as a parameter; nothing else changes.Verification
Suite 1506 tests / 156 suites pass (+3 pinning the share, the floor, the ceiling, and that share + rigid sections fit a 700pt rail). swiftlint 0 errors,
swift-format --strictclean. Needs a human's eyes on a short window.🤖 Generated with Claude Code
https://claude.ai/code/session_019A6NULwEiBXEdRXwEKKcRH