Add write-path probes for the non-blocking writer (#291) - #294
Merged
Merged
Conversation
Partial writes resuming without truncation or duplication against a 2 KB receive buffer, a close landing mid-frame ending the stream rather than corrupting it, and a peer that vanishes while the writer is parked being noticed without anyone closing the channel. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01BTGxgXNsZkDeiZE273zbqL
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Test-only. Lands the probe suite from the #291 re-review, for code that is already on
main.#291 replaced the channel's blocking
write(2)with non-blockingsendplus a boundedpoll, because a thread parked inside a blocking write on a unix socket is not reliably woken by another thread'sshutdown— which hadcloseAndWaithanging the full test suite. That write path merged with only its own tests plus the reviewer's earlier probes; these are the ones written specifically to attack it.What they cover:
EINTR,EAGAIN, andwritten == 0all take their intended branch.Gate on this branch: 1604 tests / 165 suites / 0 failures, no restarts — the reviewer independently measured the same count.
Authored by the reviewer on
review/291-probes-2, cherry-picked unchanged; I only verified it.Related to #288, #291.
🤖 Generated with Claude Code
https://claude.ai/code/session_01BP43ags4cn8fq2ZZdv85J9