Keep the briefing when a medium goal overruns the typed line - #347
Merged
Merged
Conversation
A goal that fit the typed line only without the briefing launched unbriefed, while longer goals took the prompt-file path and kept it. Shed in the right order: pointer + briefing first, then drop the briefing only if that still overruns. The unbriefed fallback also keeps the wake pointer now. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #345.
Problem
When the launch command overran the typed-line budget,
ZmxSessionLauncher.arguments(forNode:)dropped the briefing first and only moved the prompt to a file if that still didn't fit. A ~600-char goal (e.g. the "Lead a team toward a goal" starter) fit once unbriefed, so it launched with no--append-system-prompt-fileand no idea it was in a graph — while multi-KB goals took the file path and kept their briefing.Fix
The shedding order is now:
The three near-identical argv builders collapse into one local
shedhelper. The unbriefed fallback also keeps the wake-digest pointer, which the old one lost.Tests
aMediumGoalMovesToAFileBeforeTheBriefingIsDroppedsizes its goal from measured baselines, so it always lands in the window that fits unbriefed but overruns briefed. It fails onmainwith the issue's exact argv (--settings …/claudeCode.json /goal xxx…, no briefing flag) and passes with the fix.graphcodesuite: 1754 tests passed (xcodebuildexit 0).swiftlint0 errors,swift format lint --strictclean.