Fix Settings crash from duplicate template identities - #359
Merged
Merged
Conversation
Opening the home directory as a recent project loaded personal templates twice and trapped in Dictionary(uniqueKeysWithValues:). Deduplicate canonical template files and give Settings rows and selections file-based identity while preserving shared template UUIDs. Signed-off-by: Zeke Arany-Lucas <93434462+ZekeAranyLucas@users.noreply.github.com> Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fix a fatal duplicate-key assertion when opening Settings with the home directory listed as a recent project. Settings previously loaded the same personal template files as both project and home templates, then passed their repeated UUIDs to
Dictionary(uniqueKeysWithValues:).Changes
SettingsTemplateEntrymodel.Test plan
SettingsTemplateEntryTests,TemplateStorageTests,TemplateUsageTests, andTemplateEditingTests.git diff --check.Checklist
git commit -s) per the DCOmake test) - targeted suites above passed; the full suite was not run.make check) - strict lint and formatting checks passed for the changed files; the full repository check was not run.