Skip to content

🎨 Palette: Add confirmation dialogs for destructive ACL actions - #633

Closed
schmug wants to merge 1 commit into
mainfrom
palette-acl-confirmation-8021464680469487374
Closed

schmug wants to merge 1 commit into
mainfrom
palette-acl-confirmation-8021464680469487374

Conversation

@schmug

@schmug schmug commented Jul 19, 2026

Copy link
Copy Markdown
Owner

💡 What: Added window.confirm dialogs to the AclMembersPanel.tsx component for three key destructive actions: removing a member, transferring ownership, and removing a group.

🎯 Why: To prevent accidental clicks from immediately mutating critical ACL state. This adds a necessary layer of friction for irreversible actions, improving overall UI safety and aligning with the project's UX guidelines.

📸 Before/After: N/A (Functional change to user flow, uses native browser dialog).

♿ Accessibility: Adds a native confirmation step which is universally accessible to screen readers out-of-the-box.


PR created automatically by Jules for task 8021464680469487374 started by @schmug

Added `window.confirm` checks to `handleRemove`, `handleTransfer`, and `handleRemoveGroup` in `app/components/AclMembersPanel.tsx` to prevent accidental data loss or unwanted permission changes, aligning with destructive UI action guidelines.

Co-authored-by: schmug <38227427+schmug@users.noreply.github.com>
@google-labs-jules

Copy link
Copy Markdown

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

@cloudflare-workers-and-pages

cloudflare-workers-and-pages Bot commented Jul 19, 2026

Copy link
Copy Markdown

Deploying with  Cloudflare Workers  Cloudflare Workers

The latest updates on your project. Learn more about integrating Git with Workers.

Status Name Latest Commit Preview URL Updated (UTC)
✅ Deployment successful!
View logs
ais-hub 5ae3cd2 Commit Preview URL

Branch Preview URL
Jul 19 2026, 05:30 AM

@cloudflare-workers-and-pages

cloudflare-workers-and-pages Bot commented Jul 19, 2026

Copy link
Copy Markdown

Deploying with  Cloudflare Workers  Cloudflare Workers

The latest updates on your project. Learn more about integrating Git with Workers.

Status Name Latest Commit Updated (UTC)
✅ Deployment successful!
View logs
agentic-inbox 5ae3cd2 Jul 19 2026, 05:32 AM

@schmug

schmug commented Jul 20, 2026

Copy link
Copy Markdown
Owner Author

Duplicate: same AclMembersPanel confirmation dialogs, re-filed daily. #628 is a superset (same three window.confirm guards plus Tooltip wrappers). Consolidating on #628.

@schmug schmug closed this Jul 20, 2026
@schmug
schmug deleted the palette-acl-confirmation-8021464680469487374 branch July 20, 2026 11:36
@google-labs-jules

Copy link
Copy Markdown

Duplicate: same AclMembersPanel confirmation dialogs, re-filed daily. #628 is a superset (same three window.confirm guards plus Tooltip wrappers). Consolidating on #628.

Understood. Acknowledging that this work is a duplicate of #628 and stopping work on this task.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant