Skip to content

🎨 Palette: Add confirmation dialogs for destructive ACL actions - #648

Closed
schmug wants to merge 1 commit into
mainfrom
palette-add-acl-confirmations-16094449045764760082
Closed

schmug wants to merge 1 commit into
mainfrom
palette-add-acl-confirmations-16094449045764760082

Conversation

@schmug

@schmug schmug commented Jul 25, 2026

Copy link
Copy Markdown
Owner

💡 What: Added window.confirm() dialogs to the destructive actions in the AclMembersPanel (removing members, transferring ownership, and removing groups).
🎯 Why: This improves UX safety by preventing accidental clicks from immediately mutating mailbox access permissions.
📸 Before/After: Visual changes demonstrated in Playwright test videos.
♿ Accessibility: Uses the native browser confirm dialog, which natively captures screen reader and keyboard focus automatically.


PR created automatically by Jules for task 16094449045764760082 started by @schmug

Co-authored-by: schmug <38227427+schmug@users.noreply.github.com>
@google-labs-jules

Copy link
Copy Markdown

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

@cloudflare-workers-and-pages

cloudflare-workers-and-pages Bot commented Jul 25, 2026

Copy link
Copy Markdown

Deploying with  Cloudflare Workers  Cloudflare Workers

The latest updates on your project. Learn more about integrating Git with Workers.

Status Name Latest Commit Preview URL Updated (UTC)
✅ Deployment successful!
View logs
ais-hub 05f462c Commit Preview URL

Branch Preview URL
Jul 25 2026, 05:33 AM

@cloudflare-workers-and-pages

Copy link
Copy Markdown

Deploying with  Cloudflare Workers  Cloudflare Workers

The latest updates on your project. Learn more about integrating Git with Workers.

Status Name Latest Commit Updated (UTC)
✅ Deployment successful!
View logs
agentic-inbox 05f462c Jul 25 2026, 05:34 AM

@schmug

schmug commented Aug 23, 2026

Copy link
Copy Markdown
Owner Author

Closing as superseded by #653.

This is one of 10 re-derivations of the same ACL confirmation-dialog change, opened by a Jules persona that has since been paused. #653 is the one kept open: it is the only variant that guards all four destructive actions including "Lock down", and it carries the clearest confirmation copy. Every variant edits .jules/palette.md, so only one can land without conflict.

@schmug schmug closed this Aug 23, 2026
@google-labs-jules

Copy link
Copy Markdown

Closing as superseded by #653.

This is one of 10 re-derivations of the same ACL confirmation-dialog change, opened by a Jules persona that has since been paused. #653 is the one kept open: it is the only variant that guards all four destructive actions including "Lock down", and it carries the clearest confirmation copy. Every variant edits .jules/palette.md, so only one can land without conflict.

Understood. Acknowledging that this work is superseded by #653 and stopping work on this task.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant