Skip to content

🎨 Palette: Add confirmation dialog for destructive ACL actions #653

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
schmug wants to merge 1 commit into
base: main
Choose a base branch
from
Open

🎨 Palette: Add confirmation dialog for destructive ACL actions #653

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 18 additions & 1 deletion app/components/AclMembersPanel.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -58,7 +58,15 @@ export function AclMembersPanel({ mailboxId }: AclMembersPanelProps) {
variant="secondary"
size="sm"
loading={lockDown.isPending}
onClick={() => lockDown.mutate(mailboxId)}
onClick={() => {
if (
window.confirm(
"Are you sure you want to lock down this mailbox? Only you will have access until you add others.",
)
) {
lockDown.mutate(mailboxId);
}
}}
data-testid="acl-lockdown-btn"
>
Lock down
Expand Down Expand Up @@ -89,6 +97,7 @@ export function AclMembersPanel({ mailboxId }: AclMembersPanelProps) {
};

const handleRemove = async (email: string) => {
if (!window.confirm(`Are you sure you want to remove ${email}?`)) return;
setRemoveError(null);
try {
await removeMember.mutateAsync(email);
Expand All @@ -100,6 +109,12 @@ export function AclMembersPanel({ mailboxId }: AclMembersPanelProps) {
};

const handleTransfer = async (email: string) => {
if (
!window.confirm(
`Are you sure you want to transfer ownership to ${email}? You will lose owner privileges.`,
)
)
return;
setTransferError(null);
try {
await transferOwnership.mutateAsync(email);
Expand All @@ -125,6 +140,8 @@ export function AclMembersPanel({ mailboxId }: AclMembersPanelProps) {
};

const handleRemoveGroup = async (group: string) => {
if (!window.confirm(`Are you sure you want to remove group ${group}?`))
return;
setRemoveGroupError(null);
try {
await removeGroup.mutateAsync(group);
Expand Down
Loading