fix(sidecar): resume Gmail history past page cap when pages are deduped - #689
Closed
cursor[bot] wants to merge 2 commits into
Closed
cursor[bot] wants to merge 2 commits into
cursor[bot] wants to merge 2 commits into
Conversation
…ed (#667) When Gmail history spans more than MAX_HISTORY_PAGES (3) and pages 1–3 are fully deduped, truncated=true froze the cursor forever and page 4+ messages were never ingested — silent data loss during mail bursts. Persist history_page_token in sidecar_state (migration 32) and pass it to listNewMessageIds so the next poll resumes from the dangling pageToken instead of re-fetching already-deduped pages. Co-authored-by: schmug <schmug@users.noreply.github.com>
…nit test Complements #667 cherry-pick: first truncated-history poll test now checks the persisted page token, and gmail-client gets a resumePageToken test. Co-authored-by: schmug <schmug@users.noreply.github.com>
Deploying with
|
| Status | Name | Latest Commit | Preview URL | Updated (UTC) |
|---|---|---|---|---|
| ✅ Deployment successful! View logs |
ais-hub | 9665ef6 | Commit Preview URL Branch Preview URL |
Aug 20 2026, 11:03 AM |
Deploying with
|
| Status | Name | Latest Commit | Updated (UTC) |
|---|---|---|---|
| ✅ Deployment successful! View logs |
agentic-inbox | 9665ef6 | Aug 20 2026, 11:04 AM |
Owner
5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
history_page_tokeninsidecar_state(migration 32) when Gmail history listing hits the 3-page cap with more pages pendinglistNewMessageIdsfrom the saved page token on the next poll instead of re-fetching pages 1–3 from the frozen cursorWhy
When a sidecar mailbox receives a burst of mail spanning more than 3 Gmail history pages,
listNewMessageIdsreturnstruncated: trueand the cursor correctly stays frozen. If pages 1–3 are fully deduped on every poll, the poller never advances to page 4+ — silent mail loss for tail messages until the cursor expires into a history-gap re-anchor.Concrete trigger: burst >3 history pages where early pages are already ingested; each poll re-lists pages 1–3 (all deduped), cursor never moves, page 4+ never fetched.
Test plan
npm testpasses locally (60 targeted: workspace-poll, gmail-client, sidecar-state)listNewMessageIdsresume-from-pageToken unit testnpm run typecheck(not run — sidecar-only change)Notes for reviewer
Cherry-pick of validated fix from prior critical-bug scans (#667). Same root cause as #607’s truncated-cursor guard; this closes the dedupe wedge where frozen cursor + re-fetch never reaches the tail.