Reuse expression parameter if value has already been seen.#671
Open
PeterN wants to merge 1 commit intoschotime:masterfrom
Open
Reuse expression parameter if value has already been seen.#671PeterN wants to merge 1 commit intoschotime:masterfrom
PeterN wants to merge 1 commit intoschotime:masterfrom
Conversation
This works in the same way for SqlExpression evaluation as SqlBuilder's ReuseParameters, except it is always on.
Owner
|
Its a tiny bit more complex than that, because if the column type you are querying against is different but the value is the same, then you will get errors, as the parameter can't be reused against multiple types. This is why it was turned off, as it can't be controlled, however we could be smarter in the linq provider as you know the type you are querying against and could reuse ones of the same type. At least you might have a better chance of getting it right anyways. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is my solution for #670. This works in the same way for SqlExpression evaluation as SqlBuilder's ReuseParameters, except it is always on.
This is helpful for e.g. search parameters. Currently,
query.Where(x => x.Field1.Contains(search) || x.Field2.Contains(search) || x.Field3.Contains(search))will duplicate the search parameter each time, resulting in a WHERE clause looking likeWHERE [Field1] LIKE '@0' OR [Field2] LIKE '@1' OR [Field3] LIKE '@2'.With this change applied, this example would become
WHERE [Field1] LIKE '@0' OR [Field2] LIKE '@0' OR [Field3] LIKE '@0'.