Skip to content

Wait for CSS generation and reload events in CLI test - #992

Merged
schultek merged 1 commit into
mainfrom
misc/css-hot-reload-test-reliability
Nov 13, 2026
Merged

schultek merged 1 commit into
mainfrom
misc/css-hot-reload-test-reliability

Conversation

@parlough

Copy link
Copy Markdown
Collaborator

Rather than polling for completed state until a set timeout.

@parlough
parlough requested a review from schultek as a code owner November 12, 2026 23:20
@github-actions

Copy link
Copy Markdown

Package Version Report

The following packages have been updated:
jaspr_test : 0.24.0-beta.0 -> 0.24.0-beta.1
jaspr : 0.24.0-beta.0 -> 0.24.0-beta.1
jaspr_builder : 0.24.0-beta.0 -> 0.24.0-beta.1
jaspr_cli : 0.24.0-beta.0 -> 0.24.0-beta.1
jaspr_router : 0.10.0-beta.0 -> 0.10.0-beta.1

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Approval recommended

No active review issues were identified for the CSS hot-reload integration test update.

No open issues 🎉

What changed in this PR

Updates the CLI CSS hot-reload integration test to wait for generation, server readiness, and reload log events instead of fixed delays and polling.

Changes:

  • Captures CLI output and waits for specific events before checking generated CSS.
  • Adds teardown to cancel output capture, stop the server, and verify successful completion.
  • Increases the overall test timeout from four to five minutes.
File Description
packages/​jaspr_cli/​test/​integration/​css_hot_reload_test.dart Replaces polling with event-based waits and adds explicit teardown checks.

Review effort: Balanced

@schultek schultek left a comment

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@schultek
schultek merged commit ac24991 into main Nov 13, 2026
7 of 12 checks passed
@schultek
schultek deleted the misc/css-hot-reload-test-reliability branch November 13, 2026 08:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants