Repository navigation
Wait for CSS generation and reload events in CLI test - #992
Merged
Merged
Conversation
Package Version ReportThe following packages have been updated: |
There was a problem hiding this comment.
🟢 Approval recommended
No active review issues were identified for the CSS hot-reload integration test update.
No open issues 🎉
What changed in this PR
Updates the CLI CSS hot-reload integration test to wait for generation, server readiness, and reload log events instead of fixed delays and polling.
Changes:
- Captures CLI output and waits for specific events before checking generated CSS.
- Adds teardown to cancel output capture, stop the server, and verify successful completion.
- Increases the overall test timeout from four to five minutes.
| File | Description |
|---|---|
packages/jaspr_cli/test/integration/css_hot_reload_test.dart |
Replaces polling with event-based waits and adds explicit teardown checks. |
Review effort: Balanced
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rather than polling for completed state until a set timeout.