Refatoração do processamento XML PMC para melhorar o tratamento de elementos <aff> e ampliar a cobertura de testes #677
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
samuelveigarangel
changed the title
samuelveigarangel
changed the title
packtools/sps/formats/pmc.py
Outdated
Comment on lines
55
to
56
| named_contents = addr_line.findall(".//named-content") | ||
| aff_with_address.extend([named_content.text for named_content in named_contents]) |
Member
There was a problem hiding this comment.
@samuelveigarangel algumas versões tem city e state no lugar de named-content. Então, você tem que considerá-los para completar aff.
packtools/sps/formats/pmc.py
Outdated
|
|
||
| addr_line = aff.find("./addr-line") | ||
| if addr_line is not None: | ||
| named_contents = addr_line.findall(".//named-content") |
Member
There was a problem hiding this comment.
No lugar de named_contents = addr_line.findall(".//named-content"), use named_contents = addr_line.xpath(".//named-content | .//state | .//city")
| named_contents = addr_line.findall(".//named-content") | ||
| aff_with_address.extend([named_content.text for named_content in named_contents]) | ||
|
|
||
| country = aff.find("./country") |
Member
There was a problem hiding this comment.
@samuelveigarangel pode adicionar o country no xpath
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
O que esse PR faz?
Refatora processamento XML PMC para melhorar o tratamento de elementos e ampliar a cobertura de testes
Onde a revisão poderia começar?
pelos commits
Como este poderia ser testado manualmente?
Algum cenário de contexto que queira dar?
N/A
Screenshots
N/A
Quais são tickets relevantes?
N/A
Referências
https://scielo.readthedocs.io/projects/scielo-publishing-schema/pt-br/latest/tagset/elemento-aff.html