add locate_app_binary helper function utilizing os.walk to enable Windows build - #191
Open
aubrika wants to merge 1 commit into
Open
add locate_app_binary helper function utilizing os.walk to enable Windows build#191aubrika wants to merge 1 commit into
aubrika wants to merge 1 commit into
Conversation
…ning on windows + tests to ensure identical behavior to prior shell-out impl
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #161 by adding a helper method utilizing
os.walkto locate the app file instead of shell-outfind, which Windows lacks. Importsplatform. Adds tests to ensure identical functionality with intent of prior implementation.Branch confirmed to build
synapse-example-applocally on bothWindows 11 Home 25H2, build 26200, x86-64andUbuntu 26.04 LTS, 7.0.0-28-generic, x86_64.