This repository was archived by the owner on Dec 6, 2023. It is now read-only.
Open
Conversation
Includes pull requests 213 and 191
Author
Unfortunately this changes on test from error to failure, presumably because the test setup is no longer correct.
Author
|
I should note that two tests (and with last push now three) fail. One appears to be precision (perhaps related to my unilateral replacement of int by int64), and another all of the elements on on the matrix lower diagonal are zero vs non-zero in the baseline, which suggests a change in dependent code, while the new one seems to be the test configuration. But I have not investigated any of these, nor do I know if the first two are introduced by my changes. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.