Draft
Conversation
The `_fake_proton_charge` provider force-set the unit to `counts/µAh`, but its input (`CorrectedDspacing`) has already been Lorentz-corrected with units of `m^4*counts`. Dividing by the wrong-unit fake charge produced `3.6e-43*m^4*s*A` instead of dimensionless values. Remove the unit override so the fake charge retains the actual data unit, making `data / proton_charge` dimensionless as expected. Closes #703 Prompt: Please investigate #703. Don't make changes yet. Follow-up: Yes, please use a new branch and make a PR. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Member
|
This appears to be related to scipp/essdiffraction#239 ? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
_fake_proton_chargeforce-set the fake charge unit tocounts/µAh, but its input (CorrectedDspacing) already carries Lorentz-corrected units (m^4·counts). Dividing by the wrong-unit charge produced3.6e-43*m^4*s*Ainstead of dimensionless values.data / proton_chargedimensionless.Test plan
[3.6e-43*m^4*s*A]Closes #703
🤖 Generated with Claude Code