Fix UnitError in temporal buffer trimming with nanosecond time coords#712
Open
SimonHeybrock wants to merge 1 commit intomainfrom
Open
Fix UnitError in temporal buffer trimming with nanosecond time coords#712SimonHeybrock wants to merge 1 commit intomainfrom
SimonHeybrock wants to merge 1 commit intomainfrom
Conversation
The `_trim_to_timespan` method hardcoded `unit='s'` for the cutoff computation, but production detector data uses `unit='ns'` for time coordinates. This caused a `UnitError: Cannot subtract ns and s` when the buffer reached capacity and trimming was triggered for the first time (after ~3-6 hours of continuous operation with 10,000-element default capacity). Convert the timespan scalar to match the time coordinate's unit using `sc.to_unit()` before subtraction. Fixes #711 Prompt: Please use a new worktree and look into #711
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
_trim_to_timespanhardcodedunit='s'for the cutoff scalar, but production detector data usesunit='ns'time coordinates — causingUnitError: Cannot subtract ns and swhen the buffer reaches capacitysc.to_unit()to convert the timespan to match the time coordinate's unitFixes #711
Test plan
unit='ns'time coordinates (scalar and thick slice)🤖 Generated with Claude Code