Conversation
|
The macos tests are fixed: https://github.com/scipp/scippneutron/actions/runs/21905945879?pr=671 |
| - name: Set up MATLAB | ||
| uses: matlab-actions/setup-matlab@v2 | ||
| with: | ||
| release: R2023b |
There was a problem hiding this comment.
This gets the latest MATLAB runtime for github actions which has fixed some issues with ARM machines.
There was a problem hiding this comment.
Ok. The problem is that horace does not officially support the latest matlab. It seems to work but we can't necessarily rely on that.
There was a problem hiding this comment.
Hmm, we put in a pin when it fails?
The osx tests passed, but the windows tests failed... |
Is that still the case? I don't see the failed test |
|
Yeah I rerun the test, it was a flaky hypothesis test timing out. |
Maybe we should address that? Or at least open an issue to fix it in a follow-up? |
|
created #672 |
3 participants
fixes #669