Skip to content

feat: switch minimal version to 1.25 matching default and latest usql #74

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
murfffi merged 2 commits into from
Feb 13, 2026
Merged

feat: switch minimal version to 1.25 matching default and latest usql #74

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e40e014
feat: switch minimal version to 1.25 matching default and latest usql
murfffi Feb 13, 2026
0caeb65
bumped golangci-lint
murfffi Feb 13, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions .github/workflows/go.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@ jobs:
- name: Set up Go
uses: actions/setup-go@v5
with:
go-version: '1.25'
go-version: '1.25.7'

- name: Build
run: go build -v ./...
Expand All @@ -45,12 +45,12 @@ jobs:
- name: Test
run: make test

oldgo:
newgo:
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v4
- uses: actions/setup-go@v5
with:
go-version: "1.24.7"
go-version: "1.26"
- name: Test
run: make test
6 changes: 3 additions & 3 deletions .github/workflows/golangci-lint.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,15 +19,15 @@ jobs:
- uses: actions/checkout@v4
- uses: actions/setup-go@v5
with:
go-version: '1.24'
go-version: '1.25'
cache: false
- name: golangci-lint
uses: golangci/golangci-lint-action@v7
uses: golangci/golangci-lint-action@v9
with:
# Require: The version of golangci-lint to use.
# When `install-mode` is `binary` (default) the value can be v1.2 or v1.2.3 or `latest` to use the latest version.
# When `install-mode` is `goinstall` the value can be v1.2.3, `latest`, or the hash of a commit.
version: v2.1.1
version: v2.9.0

# Optional: working directory, useful for monorepos
# working-directory: somedir
Expand Down
2 changes: 1 addition & 1 deletion go.mod
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
module github.com/sclgo/usqlgen

go 1.24.6
go 1.25.7
Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist bot Feb 13, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

The go directive is set to a specific patch version (1.25.7). It's generally better to specify only the major and minor version (1.25) to define the minimum required language version. This avoids forcing all developers and build systems to upgrade to a specific patch release, making the project easier to contribute to. This also aligns better with the PR title which mentions a minimal version of 1.25.

go 1.25


require (
github.com/ansel1/merry/v2 v2.2.3
Expand Down
Loading