Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request updates the Go version to 1.25.8, refactors imports and removes a lint suppression in filetools.go, and introduces a local installation of golangci-lint in the Makefile. A bug was identified in the Makefile where an invalid version of golangci-lint (v2.11.4) was specified, which will cause the installation to fail as the tool is currently on version v1.x.
| # We install golangci-lint as recommended in the docs. See the same docs for a discussion about go run and | ||
| # go get -tool alternatives - https://golangci-lint.run/docs/welcome/install/ . | ||
| # Delete tools/golangci-lint if this target is updated (may be automated in the future) | ||
| curl -sSfL https://raw.githubusercontent.com/golangci/golangci-lint/HEAD/install.sh | sh -s -- -b ./tools v2.11.4 No newline at end of file |
There was a problem hiding this comment.
The version v2.11.4 for golangci-lint appears to be incorrect. The current major version of golangci-lint is v1, and there is no v2.11.4 release available in the official repository. This will cause the installation script to fail as it won't find a matching release on GitHub. Please use a valid version, such as the latest stable v1.64.5.
curl -sSfL https://raw.githubusercontent.com/golangci/golangci-lint/HEAD/install.sh | sh -s -- -b ./tools v1.64.5
also bump go.mod to 1.25.8 to collect vulnerability fixes
murfffi
changed the title
1 participant
Moving to 1.26 includes: